Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove general implicit solver functions #268

Closed
Tracked by #135
juliasloan25 opened this issue Jul 14, 2023 · 1 comment
Closed
Tracked by #135

Remove general implicit solver functions #268

juliasloan25 opened this issue Jul 14, 2023 · 1 comment
Assignees
@juliasloan25
Labels
enhancement New feature or request
Milestone
O2.3.6 Implicit s...

Comments

@juliasloan25
Copy link
Member

Is your feature request related to a problem? Please describe.
When implementing the implicit solver for the soil water equation, we had to add some auxiliary functions to use ClimaTimeSteppers, including linsolve, thomas_algorithm, etc here. Since these are not specific to ClimaLSM, they should be moved to ClimaCore.jl.

ClimaCore.jl #1634 adds these functions to ClimaCore - after this, we can import the functions from there and delete them here.
@juliasloan25 juliasloan25 added the enhancement New feature or request label Jul 14, 2023
@juliasloan25 juliasloan25 mentioned this issue Jul 25, 2023
Merged
1 task
@juliasloan25
Copy link
Member Author

Closed by #247

@juliasloan25 juliasloan25 mentioned this issue Mar 4, 2024
Closed
15 tasks
@juliasloan25 juliasloan25 self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
enhancement New feature or request
Projects
None yet
Milestone
O2.3.6 Implicit solver for full soil ...
Development

No branches or pull requests
1 participant
@juliasloan25