You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Our new BulkAlbedoTemporal type takes in a surface argument of type ClimaLSM.Domain.AbstractDomain (see here). This works within ClimaLSM, but ClimaCoupler also needs to use this constructor, and shouldn't depend on types internal to ClimaLSM.Domains.
Describe the solution you'd like
Instead of passing in the domain, we should pass in the ClimaCore space (i.e. change this argument to type ClimaCore.Spaces.AbstractSpace). This will still give us all the information we need to read in the albedo on the surface space.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Our new BulkAlbedoTemporal type takes in a surface argument of type
ClimaLSM.Domain.AbstractDomain
(see here). This works within ClimaLSM, but ClimaCoupler also needs to use this constructor, and shouldn't depend on types internal toClimaLSM.Domains
.BulkAlbedoTemporal introduced in #280
Describe the solution you'd like
Instead of passing in the domain, we should pass in the ClimaCore space (i.e. change this argument to type
ClimaCore.Spaces.AbstractSpace
). This will still give us all the information we need to read in the albedo on the surface space.The text was updated successfully, but these errors were encountered: