Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkAlbedoTemporal - use ClimaCore space #299

Closed
juliasloan25 opened this issue Aug 17, 2023 · 0 comments · Fixed by #300
Closed

BulkAlbedoTemporal - use ClimaCore space #299

juliasloan25 opened this issue Aug 17, 2023 · 0 comments · Fixed by #300
Assignees
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Aug 17, 2023

Is your feature request related to a problem? Please describe.
Our new BulkAlbedoTemporal type takes in a surface argument of type ClimaLSM.Domain.AbstractDomain (see here). This works within ClimaLSM, but ClimaCoupler also needs to use this constructor, and shouldn't depend on types internal to ClimaLSM.Domains.

BulkAlbedoTemporal introduced in #280

Describe the solution you'd like
Instead of passing in the domain, we should pass in the ClimaCore space (i.e. change this argument to type ClimaCore.Spaces.AbstractSpace). This will still give us all the information we need to read in the albedo on the surface space.

@juliasloan25 juliasloan25 added the enhancement New feature or request label Aug 17, 2023
@juliasloan25 juliasloan25 self-assigned this Aug 17, 2023
@bors bors bot closed this as completed in #300 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant