Read albedo from file over time (v2)

[juliasloan25]

Purpose

Using the recently-added FileReader module, this PR adds a new albedo model type that allows us to read in albedo from a NetCDF file that varies in time.

Closes #243

To-do

• Copy infrastructure, tests from Read albedo over time (v1) #260
• Update BulkAlbedoTemporal test to work
  • Add test for interpolate_data when current date = a date in the file
    • Maybe add a case to explicitly just return current data

Notes

• For BulkAlbedoStatic, we use Regridder.MapInfo to store the albedo dataset file info. For BulkAlbedoTemporal, we use FileReader.PrescribedData. We can probably update BulkAlbedoStatic to use PrescribedData instead, or one of the component structs of PrescribedData (FileInfo?)
  • Maybe in a separate PR we can work on simplify these to just use one struct - see unify BulkAlbedoStatic, BulkAlbedoTemporal types #295
• This PR introduces a test for BulkAlbedoTemporal in test/standalone/Bucket/albedo_types.jl, which also tests some functionality of FileReader.interpolate_data that isn't tested elsewhere. This test involves a lot of setup (making a PrescribedData object and everything inside of it, reading in a data file for many points in time, creating a space) which is required for the BulkAlbedoTemporal test anyway, so it was easier to just write it there. However, we should really add a more thorough test for interpolate_data in test/shared_utilities/file_reader.jl so the module's functions are thoroughly tested there.
  • Maybe this could be part of a separate PR so it doesn't block this from getting merged - see Add test for FileReader.interpolate_data #285

---

• I have read and checked the items on the review checklist.

[kmdeck]

you wrote:

For BulkAlbedoStatic, we use [Regridder.MapInfo](https://github.com/CliMA/ClimaLSM.jl/blob/main/src/shared_utilities/Regridder.jl#L357) to store the albedo dataset file info. For BulkAlbedoTemporal, we use [FileReader.PrescribedData](https://github.com/CliMA/ClimaLSM.jl/blob/main/src/shared_utilities/FileReader.jl#L96). We can probably update BulkAlbedoStatic to use PrescribedData instead, or one of the component structs of PrescribedData (FileInfo?)

    Maybe in a separate PR we can work on simplify these to just use one struct

this is a great idea.

[kmdeck]

perhaps we can also test set_initial_parameter_field! and next_albedo directly (aside from via update_aux and set_initial_aux_state)

[juliasloan25]

yeah, good idea

[juliasloan25]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climalsm-ci
• ci 1.9 - macOS-latest
• ci 1.9 - ubuntu-latest
• docbuild
• format