Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Prescribed Soil" for canopy and biogeochemistry #674

Open
kmdeck opened this issue Jun 24, 2024 · 0 comments
Open

Refactor "Prescribed Soil" for canopy and biogeochemistry #674

kmdeck opened this issue Jun 24, 2024 · 0 comments
Assignees
Labels
SDI Software Design Issue

Comments

@kmdeck
Copy link
Collaborator

kmdeck commented Jun 24, 2024

Purpose

Both the canopy and the biogeochemistry models require time varying soil properties when run in standalone mode. These do not make use of ClimaUtilities TimeVaryingInput, require two "PrescribedSoil" structs, and, when run in integrated mode, also require two "Prognostic Soil" structs.

The idea here is to introduce a "PrescribedSoilDriver" in shared_utilities/drivers.jl which has the fields needed by these standalone models. Then, we can make use of the same "update drivers" technology to update the soil properties as needed, in place.

See kd/soil_bio_consistencykd/soil_bio_consistency for sketch

***Should biogeochemistry be a standalone component with a prescribed soil model, or should this be a new type of soil model?

Cost/benefits/risks

This would have nice parallels between Prescribed/Coupled atmos (Prescribed/Prognostic soil's), and be clearer overall

Producers

Kat

Components

Introduce PrescribedSoil driver with things needed for the biogeochemistry and canopy models.

Introduce a single PrognosticSoil driver which points towards the correct allocated fields in the integrated case

Task breakdown

  1. Generalize drivers beyond radiation and atmospheric variables
  2. Create PrescribedOrganicCarbon driver using a Spatially Varying Input and use it in biogeochemistry and in all integrated runs. This will also remove an allocation of a 3d field. Eventually, when we add a carbon model, this would be an alternative.
  3. Create PrescribedSoil driver and use it in biogeochemistry (temperature and moisture)
  4. Use the same PrescribedSoil driver in Canopy
  5. Create Prognostic Soil and use in soil canopy model and soil biogeochemistry model

Does (2) encompass LAI? or we will treat Biomass as a different prescribed/prognostic component?

Reviewers

@AlexisRenchon @Sbozzolo

@kmdeck kmdeck added the SDI Software Design Issue label Jun 24, 2024
@kmdeck kmdeck self-assigned this Jun 24, 2024
@kmdeck kmdeck mentioned this issue Jul 2, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDI Software Design Issue
Projects
None yet
Development

No branches or pull requests

1 participant