Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublimation #373

Merged
merged 1 commit into from
May 21, 2024
Merged

Sublimation #373

merged 1 commit into from
May 21, 2024

Conversation

kmdeck
Copy link
Collaborator

@kmdeck kmdeck commented Nov 6, 2023

Purpose

Implement a simple model for soil sublimation, documented in the Clima design doc.

To-do

Content

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,
  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck changed the title wip sublimation Sublimation Nov 6, 2023
@kmdeck kmdeck linked an issue Nov 6, 2023 that may be closed by this pull request
5 tasks
@kmdeck kmdeck mentioned this pull request Nov 6, 2023
5 tasks
@kmdeck kmdeck self-assigned this Mar 7, 2024
@kmdeck kmdeck added enhancement New feature or request AMIP labels May 11, 2024
@kmdeck kmdeck marked this pull request as ready for review May 15, 2024 20:50
@kmdeck kmdeck requested a review from juliasloan25 May 15, 2024 20:50
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kat, this looks great!

src/integrated/soil_canopy_model.jl Show resolved Hide resolved
@kmdeck kmdeck enabled auto-merge May 20, 2024 18:25
@kmdeck kmdeck merged commit 91a4eeb into main May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMIP enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Climate Drivers for Soil
2 participants