Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified quality check, and gapfilling, and improved plotting #529

Closed
wants to merge 2 commits into from

Conversation

mitraA90
Copy link
Collaborator

Purpose

This PR includes modifications for gapfilling and plotting in run_fluxnet.jl, plot_utils.jl, and data_tools.jl, addressing specific issues related to using longterm mean and general quality flags for gapfilling and plotting enhancements.

Content

This PR introduces changes to run_fluxnet.jl, plot_utils.jl, and data_tools.jl. Specifically, I have:

  • plot_utils.jl now contains a new function plot_and_save that plots and save if needed the required model met-drivers under "results/inputs"
  • data_tools.jl now uses the data from same hour and same day across all years if any data is absent. If no such data is available the absent data is filled up with a coarser representative dataset as stated in "time_criteria"
  • run_fluxnet.jl is modified as necessary and plotting output data is modified.

In the Content, I have included:

  • Tests to verify the modifications.
  • Appropriate docstrings on all functions, structs, and modules, and included relevant documentation to improve clarity and maintainability.
  • kat comments are included

Request for Review

@Espeer5 and @kmdeck, please review the changes and provide your feedback. Your insights would be invaluable in resolving the remaining issues and finalizing the PR for merge.

@mitraA90 mitraA90 added the enhancement New feature or request label Feb 29, 2024
@mitraA90 mitraA90 self-assigned this Feb 29, 2024
@AlexisRenchon
Copy link
Member

Hey Mitra,
You can assign reviewers on the top right of this web page.
I assigned myself (I'll have a look next week)

@mitraA90
Copy link
Collaborator Author

mitraA90 commented Feb 29, 2024 via email

run_fluxnet.jl data_tools.jl and plot_utils.jl are modified

format is corrected

formatted again this time by climaformat.jl

formatted again this time by climaformat.jl

manual formatting

manual formatting

manual formatting

manual formatting

bucket albedo parameterization cleanup

changes made

packages precompiled ClimaLandSimulations failed

all Pkgs precompile, and code is running well

kat comments on PR #527 are included

md removed

generated docs are-removed
@AlexisRenchon
Copy link
Member

I squashed your commits to 1,
Are the changes to experiments/Manifest.toml intentional?
If not, we should keep the one from main (I can help).

@mitraA90 mitraA90 closed this May 22, 2024
@mitraA90 mitraA90 deleted the ma/fluxnet_sites branch May 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants