Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preallocate regridded spaces #72

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Preallocate regridded spaces #72

merged 3 commits into from
Jul 2, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Jul 2, 2024

Reducing allocations. And expose regridded_snapshot!

@Sbozzolo Sbozzolo force-pushed the gb/reorder branch 4 times, most recently from 2eb1e92 to 98c3578 Compare July 2, 2024 21:54
@Sbozzolo Sbozzolo requested a review from kmdeck July 2, 2024 21:54
@Sbozzolo Sbozzolo force-pushed the gb/reorder branch 4 times, most recently from 0d38d5b to ecde987 Compare July 2, 2024 22:06
Copy link

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change! thanks!

ext/TimeVaryingInputsExt.jl Show resolved Hide resolved
ext/TimeVaryingInputsExt.jl Outdated Show resolved Hide resolved
ext/TimeVaryingInputsExt.jl Outdated Show resolved Hide resolved
@Sbozzolo Sbozzolo force-pushed the gb/reorder branch 2 times, most recently from 19d1eac to c5f0c28 Compare July 2, 2024 22:26
And reduce allocations in regridding by preallocting the target field

TODO: make this dependent on the stencil size
@Sbozzolo Sbozzolo merged commit b9a37f3 into main Jul 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants