Move first order moisture flux to new tendency specification #1725

charleskawczynski · 2020-11-09T14:47:25Z

Description

This PR

moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for experiments/AtmosLES/bomex_model.jl with moisture_model == "nonequilibrium", but I haven't checked the results.
Renames flux_moisture! to flux_first_order! in efforts to standardize some of the AtmosModel method calls
Adds Moisture <: PrognosticVariable to combine specification for the moisture variables.

Code follows the style guidelines OR N/A.
Unit tests are included OR N/A.
Code is exercised in an integration test OR N/A.
Documentation has been added/updated OR N/A.

kpamnany

it seems that NonEquilMoist models are not tested

Maybe add bomex_les.jl --moisture-model=nonequilibrium also to the pipeline?

src/Atmos/Model/AtmosModel.jl

src/Atmos/Model/atmos_tendencies.jl

charleskawczynski · 2020-11-09T15:25:05Z

Maybe add bomex_les.jl --moisture-model=nonequilibrium also to the pipeline?

I'll add the single stack one, since this is cheaper but still exercises the kernels.

trontrytel · 2020-11-09T17:27:04Z

it seems that NonEquilMoist models are not tested

Maybe add bomex_les.jl --moisture-model=nonequilibrium also to the pipeline?

The plan was to have a full bomex run with both equilibrium and nonequilibrium mositure as a part of weekly/nightly tests. Once we have them

trontrytel · 2020-11-09T17:37:19Z

In general I would say that moisture variables (q_tot, q_liq and q_ice) will have the same flux but different source terms. And then the upcoming precipitation variables (q_rai and q_sno) will have different fluxes and source terms.

charleskawczynski · 2020-11-09T17:44:47Z

In general I would say that moisture variables (q_tot, q_liq and q_ice) will have the same flux but different source terms. And then the upcoming precipitation variables (q_rai and q_sno) will have different fluxes and source terms.

That's great, we can group them as we need, then.

charleskawczynski · 2020-11-09T17:59:15Z

The plan was to have a full bomex run with both equilibrium and nonequilibrium mositure as a part of weekly/nightly tests. Once we have them

Sounds good. I'll leave it for now so that we know that the kernels are syntactically correct, but I agree that we should hook in QA tests.

glwagner

Unfortunately my limited understanding of the balance law framework hinders my ability to review this PR. Nothing egregious pops out to me so I'm approving.

A higher-level question is --- does it make sense to modularize the microphysics implementation a bit more? Right now it looks like terms like "mass, momentum, energy" prognostic variables are specified alongside moisture terms. A more modular design might separate these implementations a bit more (I can't tell if they just happen to be nearby in the code, or if their proximity reflects a deeper entanglement).

Can you use independent balance laws to different aspects of the equations (one for "primary" variables like mass, momentum, and energy, another for microphysics variables, another for passive chemical species) to enforce / ease this modularization?

charleskawczynski · 2020-11-13T14:27:41Z

A higher-level question is --- does it make sense to modularize the microphysics implementation a bit more? Right now it looks like terms like "mass, momentum, energy" prognostic variables are specified alongside moisture terms. A more modular design might separate these implementations a bit more (I can't tell if they just happen to be nearby in the code, or if their proximity reflects a deeper entanglement). Can you use independent balance laws to different aspects of the equations (one for "primary" variables like mass, momentum, and energy, another for microphysics variables, another for passive chemical species) to enforce / ease this modularization?

They are modularized in the sense that we have fallback methods for (for example) flux_first_order!(atmos.moisture, ...) which do nothing when atmos.moisture isa DryModel, and do moisture / microphysics things for moist models.

glwagner · 2020-11-13T14:58:09Z

They are modularized in the sense that we have fallback methods for (for example) flux_first_order!(atmos.moisture, ...) which do nothing when atmos.moisture isa DryModel, and do moisture / microphysics things for moist models.

For sure, my questions is about "more" modularization (not necessarily functionally but just by writing the code differently, eg by using different files), which makes it easier for future developers to build further without impacting the readability of core stuff.

charleskawczynski · 2020-11-19T17:21:28Z

bors r+

1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-19T17:22:14Z

Build failed:

buildkite/climatemachine-ci

charleskawczynski · 2020-11-19T17:24:51Z

bors r+

1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-19T18:28:40Z

Build failed:

buildkite/climatemachine-ci

charleskawczynski · 2020-11-20T15:00:29Z

bors r+

1687: Extract remaining citations r=charleskawczynski a=charleskawczynski ### Description Extracts remaining references/citations to `docs/bibliography.bib`. 1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-20T15:59:13Z

Build failed (retrying...):

buildkite/climatemachine-ci

1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-20T16:58:20Z

Build failed:

buildkite/climatemachine-ci

charleskawczynski · 2020-11-20T20:21:07Z

bors r+

1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-20T21:20:05Z

Build failed:

buildkite/climatemachine-ci

charleskawczynski · 2020-11-20T22:26:58Z

bors r+

1725: Move first order moisture flux to new tendency specification r=charleskawczynski a=charleskawczynski ### Description This PR - moves the first order moisture flux to the new tendency specification. I can confirm that the tendency table is updated, for `experiments/AtmosLES/bomex_model.jl` with `moisture_model == "nonequilibrium"`, but I haven't checked the results. - Renames `flux_moisture!` to `flux_first_order!` in efforts to standardize some of the AtmosModel method calls - Adds `Moisture <: PrognosticVariable` to combine specification for the moisture variables. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>

bors · 2020-11-21T01:09:15Z

Build failed:

buildkite/climatemachine-ci

charleskawczynski · 2020-11-21T01:16:15Z

bors r+

bors · 2020-11-21T03:09:35Z

Build succeeded:

charleskawczynski added the Atmos Atmosphere label Nov 9, 2020

charleskawczynski requested review from trontrytel and kpamnany November 9, 2020 14:47

kpamnany reviewed Nov 9, 2020

View reviewed changes

src/Atmos/Model/AtmosModel.jl Outdated Show resolved Hide resolved

src/Atmos/Model/atmos_tendencies.jl Outdated Show resolved Hide resolved

charleskawczynski force-pushed the ck/tend_f1_moisture branch 4 times, most recently from 4279a09 to a42811b Compare November 9, 2020 16:54

charleskawczynski force-pushed the ck/tend_f1_moisture branch from a42811b to a2a4722 Compare November 9, 2020 17:58

charleskawczynski requested a review from glwagner November 12, 2020 15:45

glwagner approved these changes Nov 13, 2020

View reviewed changes

charleskawczynski force-pushed the ck/tend_f1_moisture branch from a2a4722 to 97e8cb3 Compare November 19, 2020 17:19

charleskawczynski force-pushed the ck/tend_f1_moisture branch from 97e8cb3 to 4e4a386 Compare November 19, 2020 17:24

charleskawczynski force-pushed the ck/tend_f1_moisture branch from 4e4a386 to ca14169 Compare November 20, 2020 14:48

charleskawczynski force-pushed the ck/tend_f1_moisture branch from ca14169 to 3cf5eaa Compare November 20, 2020 22:26

Move moisture O1 flux to new tend spec

52fb4c1

charleskawczynski force-pushed the ck/tend_f1_moisture branch from 3cf5eaa to 52fb4c1 Compare November 21, 2020 01:16

bors bot merged commit 673a30c into master Nov 21, 2020

bors bot deleted the ck/tend_f1_moisture branch November 21, 2020 03:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move first order moisture flux to new tendency specification #1725

Move first order moisture flux to new tendency specification #1725

charleskawczynski commented Nov 9, 2020 •

edited

Loading

kpamnany left a comment

charleskawczynski commented Nov 9, 2020

trontrytel commented Nov 9, 2020

trontrytel commented Nov 9, 2020

charleskawczynski commented Nov 9, 2020

charleskawczynski commented Nov 9, 2020

glwagner left a comment

charleskawczynski commented Nov 13, 2020

glwagner commented Nov 13, 2020

charleskawczynski commented Nov 19, 2020

bors bot commented Nov 19, 2020

charleskawczynski commented Nov 19, 2020

bors bot commented Nov 19, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 20, 2020

bors bot commented Nov 20, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 20, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 21, 2020

charleskawczynski commented Nov 21, 2020

bors bot commented Nov 21, 2020

Move first order moisture flux to new tendency specification #1725

Move first order moisture flux to new tendency specification #1725

Conversation

charleskawczynski commented Nov 9, 2020 • edited Loading

Description

kpamnany left a comment

Choose a reason for hiding this comment

charleskawczynski commented Nov 9, 2020

trontrytel commented Nov 9, 2020

trontrytel commented Nov 9, 2020

charleskawczynski commented Nov 9, 2020

charleskawczynski commented Nov 9, 2020

glwagner left a comment

Choose a reason for hiding this comment

charleskawczynski commented Nov 13, 2020

glwagner commented Nov 13, 2020

charleskawczynski commented Nov 19, 2020

bors bot commented Nov 19, 2020

charleskawczynski commented Nov 19, 2020

bors bot commented Nov 19, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 20, 2020

bors bot commented Nov 20, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 20, 2020

charleskawczynski commented Nov 20, 2020

bors bot commented Nov 21, 2020

charleskawczynski commented Nov 21, 2020

bors bot commented Nov 21, 2020

charleskawczynski commented Nov 9, 2020 •

edited

Loading