This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Support for kernels on subsets of variables #1915
Draft
simonbyrne
wants to merge
8
commits into
master
Choose a base branch
from
sb/subset
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryBuild failed: |
Comment on lines
41
to
+44
struct Prognostic <: AbstractStateType end | ||
|
||
struct PrognosticIn <: AbstractStateType end | ||
struct PrognosticOut <: AbstractStateType end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
struct Prognostic <: AbstractStateType end | |
struct PrognosticIn <: AbstractStateType end | |
struct PrognosticOut <: AbstractStateType end | |
abstract type AbstractStreamType end | |
struct In <: AbstractStreamType end | |
struct Out <: AbstractStreamType end | |
struct InOut <: AbstractStreamType end | |
struct Prognostic{T<: AbstractStreamType} <: AbstractStateType end | |
Prognostic() = Prognostic{InOut}() |
Would something like this be simpler if we plan to extend this to other AbstractStateType
's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. There is the chance we might want them to be specific to each kernel as well.
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows use of MPIStateArrays with different state variables then defined in the kernel. Should make it easier to operate on subsets of state.