Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Support for kernels on subsets of variables #1915

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

simonbyrne
Copy link
Member

Description

Allows use of MPIStateArrays with different state variables then defined in the kernel. Should make it easier to operate on subsets of state.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 11, 2021
@bors
Copy link
Contributor

bors bot commented Jan 11, 2021

try

Build failed:

Comment on lines 41 to +44
struct Prognostic <: AbstractStateType end

struct PrognosticIn <: AbstractStateType end
struct PrognosticOut <: AbstractStateType end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
struct Prognostic <: AbstractStateType end
struct PrognosticIn <: AbstractStateType end
struct PrognosticOut <: AbstractStateType end
abstract type AbstractStreamType end
struct In <: AbstractStreamType end
struct Out <: AbstractStreamType end
struct InOut <: AbstractStreamType end
struct Prognostic{T<: AbstractStreamType} <: AbstractStateType end
Prognostic() = Prognostic{InOut}()

Would something like this be simpler if we plan to extend this to other AbstractStateType's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. There is the chance we might want them to be specific to each kernel as well.

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 12, 2021
@bors
Copy link
Contributor

bors bot commented Jan 12, 2021

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 13, 2021
@bors
Copy link
Contributor

bors bot commented Jan 13, 2021

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 13, 2021
@bors
Copy link
Contributor

bors bot commented Jan 13, 2021

try

Build failed:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants