Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the standard_N_q functionality #169

Merged
merged 9 commits into from
May 22, 2024
Merged

Rewrite the standard_N_q functionality #169

merged 9 commits into from
May 22, 2024

Conversation

edejong-caltech
Copy link
Member

@edejong-caltech edejong-caltech commented May 22, 2024

Purpose

Replaces quadgk with analytical integrals where possible.

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.60%. Comparing base (29b59bb) to head (de913a7).
Report is 17 commits behind head on main.

Files Patch % Lines
src/ParticleDistributions/ParticleDistributions.jl 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   98.17%   97.60%   -0.58%     
==========================================
  Files           8        9       +1     
  Lines         493      500       +7     
==========================================
+ Hits          484      488       +4     
- Misses          9       12       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me. The only thing is that the documentation is still about Cloudy in Microphysics. It would be good to edit it or open an issue to edit it later.

@edejong-caltech edejong-caltech marked this pull request as ready for review May 22, 2024 23:59
@edejong-caltech edejong-caltech merged commit 10078f6 into main May 22, 2024
7 of 9 checks passed
@edejong-caltech edejong-caltech deleted the ej/N_q branch May 22, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants