Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poisson solver tests use CenterField to represent fields at Faces #1867

Closed
glwagner opened this issue Jul 17, 2021 · 1 comment
Closed

Poisson solver tests use CenterField to represent fields at Faces #1867

glwagner opened this issue Jul 17, 2021 · 1 comment
Labels
cleanup 🧹 Paying off technical debt numerics 🧮 So things don't blow up and boil the lobsters alive

Comments

@glwagner
Copy link
Member

The poisson solver tests have a mysterious property:

Ru = CenterField(arch, grid, u_bcs)
Rv = CenterField(arch, grid, v_bcs)
Rw = CenterField(arch, grid, w_bcs)
U = (u=Ru, v=Rv, w=Rw)

whereby CenterField is used for Ru, Rv, and Rw --- fields that should be located on faces, and have boundary conditions appropriate for velocity fields.

When these fields are merely relocated to the correct location, the tests fail.

Since by all accounts the Poisson solver is correct, there is probably something wrong with the tests. But we can't really be sure about either while the tests contain an obvious inconsistency. We should probably fix these tests.

@ali-ramadhan, do you remember why we use CenterField for Ru, Rv, and Rw? The code was added in this PR: #834.

@glwagner
Copy link
Member Author

I'm closing this issue because I'm judging that it's not of current, timely relevance to Oceananigans development. If you would like to make it a higher priority or if you think the issue was closed in error please feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt numerics 🧮 So things don't blow up and boil the lobsters alive
Projects
None yet
Development

No branches or pull requests

1 participant