Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we test also models run with tuple of closures and/or using different models? #2047

Closed
navidcy opened this issue Nov 10, 2021 · 2 comments
Labels
GPU 👾 Where Oceananigans gets its powers from testing 🧪 Tests get priority in case of emergency evacuation turbulence closures 🎐

Comments

@navidcy
Copy link
Collaborator

navidcy commented Nov 10, 2021

E.g., in addition of this:

function time_stepping_works_with_closure(arch, FT, Closure; buoyancy=Buoyancy(model=SeawaterBuoyancy(FT)))
# Add TKE tracer "e" to tracers when using CATKEVerticalDiffusivity
tracers = [:T, :S]
Closure === CATKEVerticalDiffusivity && push!(tracers, :e)
# Use halos of size 2 to accomadate time stepping with AnisotropicBiharmonicDiffusivity.
grid = RegularRectilinearGrid(FT; size=(1, 1, 1), halo=(2, 2, 2), extent=(1, 2, 3))
model = NonhydrostaticModel(grid=grid, architecture=arch,
closure=Closure(FT), tracers=tracers, buoyancy=buoyancy)
time_step!(model, 1, euler=true)
return true # Test that no errors/crashes happen when time stepping.
end

we also have tests using, e.g., closure = (AnisotropicDiffusivity(FT), Closure(FT)) and also some tests using, e.g., HydrostaticFreeSurfaceModel?

@navidcy navidcy added GPU 👾 Where Oceananigans gets its powers from testing 🧪 Tests get priority in case of emergency evacuation turbulence closures 🎐 labels Nov 10, 2021
@navidcy
Copy link
Collaborator Author

navidcy commented Nov 10, 2021

(The backstory of this is that I wasn't able to run HydrostaticFreeSurfaceModel with two closures on the GPU...)

@glwagner
Copy link
Member

Pretty sure we do test closure tuples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU 👾 Where Oceananigans gets its powers from testing 🧪 Tests get priority in case of emergency evacuation turbulence closures 🎐
Projects
None yet
Development

No branches or pull requests

2 participants