[WIP] Reverse k index so that k=1 is at the bottom. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also used ifelse function evaluations instead of if-else statements.
This is because at the surface and bottom it will attempt to access an array out of bounds.
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 52.71% 53.15% +0.44%
==========================================
Files 19 19
Lines 645 649 +4
==========================================
+ Hits 340 345 +5
+ Misses 305 304 -1
Continue to review full report at Codecov.
|
|
We should add documentation on the numerical implementation of boundary conditions in this PR. |
ali-ramadhan
changed the title
ali-ramadhan
added
the
numerics 🧮
|
Closing this PR as it's super stale. Can use the proposed changes as a reference when we revisit this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverses the vertical index k so that k=1 corresponds to the bottom of the domain. More details can be found in #90.
WIP because I'm not 100% sure I'm calculating differences and averages at k=1 and k=Nz correctly now. Will have to ask @jm-c to make sure.
Resolves #90