Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when throwing exception during grid validation #2845

Merged

Conversation

ali-ramadhan
Copy link
Member

Currently an error during grid validation is actually not printed, instead you get

ERROR: UndefVarError: N! not defined

as string interpolation is expecting a variable called N! when the variable is N.

This PR fixes this.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Probably bump minor version?

@ali-ramadhan ali-ramadhan force-pushed the ar/fix-validate-dimension-specification-exception branch from c65ae51 to 35dc402 Compare December 5, 2022 14:52
@ali-ramadhan ali-ramadhan merged commit 7c82475 into main Dec 5, 2022
@ali-ramadhan ali-ramadhan deleted the ar/fix-validate-dimension-specification-exception branch December 5, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants