Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke these? #187

Closed
navidcy opened this issue Feb 8, 2022 · 2 comments
Closed

Nuke these? #187

navidcy opened this issue Feb 8, 2022 · 2 comments
Labels
🧹 cleanup ❓ question Further information is requested

Comments

@navidcy
Copy link
Collaborator

navidcy commented Feb 8, 2022

https://github.com/CliMA/OceanTurbulenceParameterEstimation.jl/blob/808ff3a25c4213d95f8cef09d9eac620cf5e619e/src/InverseProblems.jl#L126-L127

Are they being used?
@navidcy navidcy added ❓ question Further information is requested 🧹 cleanup labels Feb 8, 2022
@navidcy
Copy link
Collaborator Author

navidcy commented Feb 8, 2022

Or add

Nobservations(ip::InverseProblem) = Nobservations(ip.simulation.model.grid)

?

@glwagner
Copy link
Member

glwagner commented Feb 8, 2022

Actually that's confusing because elsewhere (and in EnsembleKalmanProcesses.jl) Nobs refers to the length of y (not the size of the batch).

In other spots we call that Nbatch.

It'll probably be useful in the future (when problems are more heterogeneous, eg consisting of multiple simulations) but it's not super useful now I don't think.

@navidcy navidcy closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 cleanup ❓ question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@navidcy @glwagner