Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this line redundant? #267

Closed
navidcy opened this issue May 7, 2022 · 3 comments · Fixed by #268
Closed

Is this line redundant? #267

navidcy opened this issue May 7, 2022 · 3 comments · Fixed by #268
Labels
❓ question Further information is requested

Comments

@navidcy
Copy link
Collaborator

navidcy commented May 7, 2022

ParameterEstimocean.jl/src/InverseProblems.jl

Line 436 in 3915d91

reshaped_y = reshape(y, Nx, Ny * Nz, Nt, Nfields) # (Nx, Ny*Nz, Nt, Nfields)

cc: @glwagner, @adelinehillier
@navidcy navidcy added the ❓ question Further information is requested label May 7, 2022
@navidcy
Copy link
Collaborator Author

navidcy commented May 7, 2022

also the comment is rather redundant, unless it explains a bit more :)

@glwagner
Copy link
Member

glwagner commented May 7, 2022

Why is redundant? Does it appear elsewhere?

@navidcy
Copy link
Collaborator Author

navidcy commented May 7, 2022 •
edited

I think reshaped_y is never used again?

@navidcy navidcy mentioned this issue May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❓ question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant variable definition CliMA/ParameterEstimocean.jl
2 participants
@navidcy @glwagner