Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convective adjustment with UKI seems to be failing? #73

Closed
navidcy opened this issue Nov 5, 2021 · 5 comments
Closed

Convective adjustment with UKI seems to be failing? #73

navidcy opened this issue Nov 5, 2021 · 5 comments
Labels
❓ question Further information is requested

Comments

@navidcy
Copy link
Collaborator

navidcy commented Nov 5, 2021

It seems to me that the UKI doesn't converge to the true parameter values. Am I interpreting this correctly?

See figure at the bottom of https://clima.github.io/OceanTurbulenceParameterEstimation.jl/dev/literated/unscented_perfect_convective_adjustment_calibration/

cc @Zhengyu-Huang

@navidcy navidcy added the ❓ question Further information is requested label Nov 5, 2021
@navidcy
Copy link
Collaborator Author

navidcy commented Nov 19, 2021

OK perhaps there is a different reason for this. The fact that UKI cannot converge to the true value for the background diffusivity may be implying that that particular value doesn't affect the results that much or that our noise levels are too high?

@navidcy
Copy link
Collaborator Author

navidcy commented Dec 4, 2021

I note that it's hard to point to a docs link since dev keeps changing. Another reason to push for #71.
The UKI problem was different when I initially posted the issue. However, still now the UKI results seem cumbersome and puzzling...

@glwagner
Copy link
Member

glwagner commented Dec 5, 2021

Why does package registration freeze the docs?

@navidcy
Copy link
Collaborator Author

navidcy commented Dec 5, 2021

Tagging does that. Nor registration. My bad...

@glwagner
Copy link
Member

glwagner commented Dec 6, 2021

Ahh

@navidcy navidcy closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants