Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build_cloud_mask! #411

Merged
merged 1 commit into from Dec 20, 2023
Merged

Refactor build_cloud_mask! #411

merged 1 commit into from Dec 20, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Dec 19, 2023 •
edited

Purpose

Refactor build_cloud_mask!.

  • I have read and checked the items on the review checklist.

szy21
szy21 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! We should have some tests for cloud fraction that are not 0 or 1 to make sure the behavior of cloud mask is correct. I will try to come up with something.

@sriharshakandala sriharshakandala merged commit 0d93d70 into main Dec 20, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sriharshakandala @szy21