Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multithreading flags #43

Merged
merged 1 commit into from
Apr 22, 2023
Merged

multithreading flags #43

merged 1 commit into from
Apr 22, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Apr 20, 2023

Purpose

  • Closes multithreading control? #31
    Note one side effect of LoopVectorization seems to be very slow compile time for github actions (though locally I don't see this)

Content

Adds 2 flags

  • one for the training (RandomFeatureMethod( ...; tullio_multithreading = true))
  • one for predict (for predict(...; tullio_multithreading=true) and predict!)
  • small docs, and testing for flags (for one thread)
  • less code duplication for predict

  • I have read and checked the items on the review checklist.

@odunbar odunbar force-pushed the orad/multithread-flag branch 5 times, most recently from c2026b2 to 2acef1b Compare April 21, 2023 22:09
format

tests for flag

test correction and refactor predict

docs

codecov

format

test fix

codecov

typo
@odunbar odunbar merged commit d55d2cc into main Apr 22, 2023
11 checks passed
@bors bors bot deleted the orad/multithread-flag branch April 22, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multithreading control?
1 participant