Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to readme docs #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add example to readme docs #142

wants to merge 2 commits into from

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Nov 2, 2022

This PR updates the readme, and provides an example.

Closes #189.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dc23bb) 93.04% compared to head (03eb6c9) 93.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files          10       10           
  Lines        1150     1150           
=======================================
  Hits         1070     1070           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charleskawczynski charleskawczynski force-pushed the ck/readme_docs branch 2 times, most recently from 5bcbf61 to 74564f7 Compare February 14, 2024 14:10
@charleskawczynski charleskawczynski marked this pull request as ready for review February 14, 2024 14:12
@charleskawczynski charleskawczynski added documentation Improvements or additions to documentation Launch Buildkite Add label to launch Buildkite labels Feb 14, 2024
README.md Outdated Show resolved Hide resolved
@glwagner
Copy link
Member

glwagner commented Feb 14, 2024

It might be nice for clarity to show what the parameters are in this example, or at least give an example of inspecting the struct to find the parameters (since they cannot be determined by reading the code). We should also show users how to change the parameters.

Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Launch Buildkite Add label to launch Buildkite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More concise and descriptive "About"
2 participants