Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Tb/aggrgation #8

Merged
merged 1 commit into from
May 21, 2020
Merged

Tb/aggrgation #8

merged 1 commit into from
May 21, 2020

Conversation

bischtob
Copy link
Contributor

Adding Julia notebook and aggregation tool. Not clean, but useful for a lot of people.

@bischtob bischtob self-assigned this May 15, 2020
@bischtob
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request May 15, 2020
8: Tb/aggrgation r=bischtob a=bischtob

Adding Julia notebook and aggregation tool. Not clean, but useful for a lot of people.

Co-authored-by: bischtob <tobias.bischoff@pm.me>
src/py/default_gcm.ipynb Outdated Show resolved Hide resolved
@charleskawczynski
Copy link
Member

I agree regarding the notebook, can't we just convert them to python? I get that notebooks are useful, but they really are not great for version control. Also, I'd be keen to help with Literate examples so that we can generate notebooks from Julia :)

@bischtob
Copy link
Contributor Author

I think we should stay away from Python in the future. It seems a lot of people like notebooks, so we'll need a way to have them.

@bors
Copy link
Contributor

bors bot commented May 16, 2020

Timed out.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #8 into master will decrease coverage by 95.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #8       +/-   ##
===========================================
- Coverage   100.00%   5.00%   -95.00%     
===========================================
  Files            1       2        +1     
  Lines            1      20       +19     
===========================================
  Hits             1       1               
- Misses           0      19       +19     
Impacted Files Coverage Δ
src/utils/make_literate.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72a2d8...fcd0078. Read the comment docs.

@LenkaNovak
Copy link
Contributor

How about we keep the python notebooks for now? I agree it would be good to use Julia by default, but it would be nice for people to have more options (e.g. if they're not too comfortable with Julia, or if they want to use python-specific packages like Iris). So the dir structure could be src/scripts/julia and src/scripts/py ...

@bischtob
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 21, 2020

Build succeeded:

  • CliMA.VizCLIMA.jl

@bors bors bot merged commit 043c5cb into master May 21, 2020
@bors bors bot deleted the tb/aggrgation branch May 21, 2020 03:17
LenkaNovak added a commit that referenced this pull request Dec 29, 2020
8: Tb/aggrgation r=bischtob a=bischtob

Adding Julia notebook and aggregation tool. Not clean, but useful for a lot of people.

Co-authored-by: lenka <lenka@caltech.edu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants