Merge branch 'backport/23.8/61561' into cherrypick/23.8/48cb228c9a88b…

…1f77c9ec10ce04107edec3e190c

.clang-format

@@ -79,7 +79,7 @@ IndentWidth: 4
 IndentWrappedFunctionNames: false
 MacroBlockBegin: ''
 MacroBlockEnd: ''
-NamespaceIndentation: None
+NamespaceIndentation: Inner
 ObjCBlockIndentWidth: 4
 ObjCSpaceAfterProperty: true
 ObjCSpaceBeforeProtocolList: true
@@ -89,7 +89,6 @@ PenaltyBreakFirstLessLess: 120
 PenaltyBreakString: 1000
 PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 60
-RemoveBracesLLVM: true
 SpaceAfterCStyleCast: false
 SpaceBeforeAssignmentOperators: true
 SpaceBeforeParens: ControlStatements

.clang-tidy

@@ -5,138 +5,155 @@
 # a) the new check is not controversial (this includes many checks in readability-* and google-*) or
 # b) too noisy (checks with > 100 new warnings are considered noisy, this includes e.g. cppcoreguidelines-*).
 
-HeaderFilterRegex: '^.*/(base|src|programs|utils)/.*(h|hpp)$'
-
-Checks: [
-  '*',
-
-  '-abseil-*',
-
-  '-altera-*',
-
-  '-android-*',
-
-  '-bugprone-assignment-in-if-condition',
-  '-bugprone-branch-clone',
-  '-bugprone-easily-swappable-parameters',
-  '-bugprone-exception-escape',
-  '-bugprone-forward-declaration-namespace',
-  '-bugprone-implicit-widening-of-multiplication-result',
-  '-bugprone-narrowing-conversions',
-  '-bugprone-not-null-terminated-result',
-  '-bugprone-reserved-identifier', # useful but too slow, TODO retry when https://reviews.llvm.org/rG1c282052624f9d0bd273bde0b47b30c96699c6c7 is merged
-  '-bugprone-unchecked-optional-access',
-
-  '-cert-dcl16-c',
-  '-cert-dcl37-c',
-  '-cert-dcl51-cpp',
-  '-cert-err58-cpp',
-  '-cert-msc32-c',
-  '-cert-msc51-cpp',
-  '-cert-oop54-cpp',
-  '-cert-oop57-cpp',
-
-  '-clang-analyzer-optin.performance.Padding',
-
-  '-clang-analyzer-unix.Malloc',
-
-  '-cppcoreguidelines-*', # impractical in a codebase as large as ClickHouse, also slow
-
-  '-darwin-*',
-
-  '-fuchsia-*',
-
-  '-google-build-using-namespace',
-  '-google-readability-braces-around-statements',
-  '-google-readability-casting',
-  '-google-readability-function-size',
-  '-google-readability-namespace-comments',
-  '-google-readability-todo',
-
-  '-hicpp-avoid-c-arrays',
-  '-hicpp-avoid-goto',
-  '-hicpp-braces-around-statements',
-  '-hicpp-explicit-conversions',
-  '-hicpp-function-size',
-  '-hicpp-member-init',
-  '-hicpp-move-const-arg',
-  '-hicpp-multiway-paths-covered',
-  '-hicpp-named-parameter',
-  '-hicpp-no-array-decay',
-  '-hicpp-no-assembler',
-  '-hicpp-no-malloc',
-  '-hicpp-signed-bitwise',
-  '-hicpp-special-member-functions',
-  '-hicpp-uppercase-literal-suffix',
-  '-hicpp-use-auto',
-  '-hicpp-use-emplace',
-  '-hicpp-vararg',
-
-  '-linuxkernel-*',
-
-  '-llvm-*',
-
-  '-llvmlibc-*',
-
-  '-openmp-*',
-
-  '-misc-const-correctness',
-  '-misc-include-cleaner', # useful but far too many occurrences
-  '-misc-no-recursion',
-  '-misc-non-private-member-variables-in-classes',
-  '-misc-confusable-identifiers', # useful but slooo
-  '-misc-use-anonymous-namespace',
-
-  '-modernize-avoid-c-arrays',
-  '-modernize-concat-nested-namespaces',
-  '-modernize-macro-to-enum',
-  '-modernize-pass-by-value',
-  '-modernize-return-braced-init-list',
-  '-modernize-use-auto',
-  '-modernize-use-default-member-init',
-  '-modernize-use-emplace',
-  '-modernize-use-nodiscard',
-  '-modernize-use-override',
-  '-modernize-use-trailing-return-type',
-
-  '-performance-inefficient-string-concatenation',
-  '-performance-no-int-to-ptr',
-  '-performance-avoid-endl',
-  '-performance-unnecessary-value-param',
-
-  '-portability-simd-intrinsics',
-
-  '-readability-avoid-unconditional-preprocessor-if',
-  '-readability-braces-around-statements',
-  '-readability-convert-member-functions-to-static',
-  '-readability-else-after-return',
-  '-readability-function-cognitive-complexity',
-  '-readability-function-size',
-  '-readability-identifier-length',
-  '-readability-identifier-naming', # useful but too slow
-  '-readability-implicit-bool-conversion',
-  '-readability-isolate-declaration',
-  '-readability-magic-numbers',
-  '-readability-named-parameter',
-  '-readability-redundant-declaration',
-  '-readability-simplify-boolean-expr',
-  '-readability-static-accessed-through-instance',
-  '-readability-suspicious-call-argument',
-  '-readability-uppercase-literal-suffix',
-  '-readability-use-anyofallof',
-
-  '-zircon-*'
-]
+# TODO Let clang-tidy check headers in further directories
+#      --> HeaderFilterRegex: '^.*/(src|base|programs|utils)/.*(h|hpp)$'
+HeaderFilterRegex: '^.*/(base)/.*(h|hpp)$'
+
+Checks: '*,
+    -abseil-*,
+
+    -altera-*,
+
+    -android-*,
+
+    -bugprone-assignment-in-if-condition,
+    -bugprone-branch-clone,
+    -bugprone-easily-swappable-parameters,
+    -bugprone-exception-escape,
+    -bugprone-implicit-widening-of-multiplication-result,
+    -bugprone-narrowing-conversions,
+    -bugprone-not-null-terminated-result,
+    -bugprone-reserved-identifier, # useful but too slow, TODO retry when https://reviews.llvm.org/rG1c282052624f9d0bd273bde0b47b30c96699c6c7 is merged
+    -bugprone-unchecked-optional-access,
+
+    -cert-dcl16-c,
+    -cert-dcl37-c,
+    -cert-dcl51-cpp,
+    -cert-err58-cpp,
+    -cert-msc32-c,
+    -cert-msc51-cpp,
+    -cert-oop54-cpp,
+    -cert-oop57-cpp,
+
+    -clang-analyzer-optin.performance.Padding,
+    -clang-analyzer-optin.portability.UnixAPI,
+    -clang-analyzer-security.insecureAPI.bzero,
+    -clang-analyzer-security.insecureAPI.strcpy,
+
+    -cppcoreguidelines-avoid-c-arrays,
+    -cppcoreguidelines-avoid-const-or-ref-data-members,
+    -cppcoreguidelines-avoid-do-while,
+    -cppcoreguidelines-avoid-goto,
+    -cppcoreguidelines-avoid-magic-numbers,
+    -cppcoreguidelines-avoid-non-const-global-variables,
+    -cppcoreguidelines-explicit-virtual-functions,
+    -cppcoreguidelines-init-variables,
+    -cppcoreguidelines-interfaces-global-init,
+    -cppcoreguidelines-macro-usage,
+    -cppcoreguidelines-narrowing-conversions,
+    -cppcoreguidelines-no-malloc,
+    -cppcoreguidelines-non-private-member-variables-in-classes,
+    -cppcoreguidelines-owning-memory,
+    -cppcoreguidelines-prefer-member-initializer,
+    -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+    -cppcoreguidelines-pro-bounds-constant-array-index,
+    -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+    -cppcoreguidelines-pro-type-const-cast,
+    -cppcoreguidelines-pro-type-cstyle-cast,
+    -cppcoreguidelines-pro-type-member-init,
+    -cppcoreguidelines-pro-type-reinterpret-cast,
+    -cppcoreguidelines-pro-type-static-cast-downcast,
+    -cppcoreguidelines-pro-type-union-access,
+    -cppcoreguidelines-pro-type-vararg,
+    -cppcoreguidelines-slicing,
+    -cppcoreguidelines-special-member-functions,
+
+    -darwin-*,
+
+    -fuchsia-*,
+
+    -google-build-using-namespace,
+    -google-readability-braces-around-statements,
+    -google-readability-casting,
+    -google-readability-function-size,
+    -google-readability-namespace-comments,
+    -google-readability-todo,
+    -google-upgrade-googletest-case,
+
+    -hicpp-avoid-c-arrays,
+    -hicpp-avoid-goto,
+    -hicpp-braces-around-statements,
+    -hicpp-explicit-conversions,
+    -hicpp-function-size,
+    -hicpp-member-init,
+    -hicpp-move-const-arg,
+    -hicpp-multiway-paths-covered,
+    -hicpp-named-parameter,
+    -hicpp-no-array-decay,
+    -hicpp-no-assembler,
+    -hicpp-no-malloc,
+    -hicpp-signed-bitwise,
+    -hicpp-special-member-functions,
+    -hicpp-uppercase-literal-suffix,
+    -hicpp-use-auto,
+    -hicpp-use-emplace,
+    -hicpp-vararg,
+
+    -linuxkernel-*,
+
+    -llvm-*,
+
+    -llvmlibc-*,
+
+    -openmp-*,
+
+    -misc-const-correctness,
+    -misc-no-recursion,
+    -misc-non-private-member-variables-in-classes,
+    -misc-confusable-identifiers, # useful but slooow
+    -misc-use-anonymous-namespace,
+
+    -modernize-avoid-c-arrays,
+    -modernize-concat-nested-namespaces,
+    -modernize-macro-to-enum,
+    -modernize-pass-by-value,
+    -modernize-return-braced-init-list,
+    -modernize-use-auto,
+    -modernize-use-default-member-init,
+    -modernize-use-emplace,
+    -modernize-use-nodiscard,
+    -modernize-use-override,
+    -modernize-use-trailing-return-type,
+
+    -performance-inefficient-string-concatenation,
+    -performance-no-int-to-ptr,
+    -performance-unnecessary-value-param,
+
+    -portability-simd-intrinsics,
+
+    -readability-braces-around-statements,
+    -readability-convert-member-functions-to-static,
+    -readability-else-after-return,
+    -readability-function-cognitive-complexity,
+    -readability-function-size,
+    -readability-identifier-length,
+    -readability-identifier-naming, # useful but too slow
+    -readability-implicit-bool-conversion,
+    -readability-isolate-declaration,
+    -readability-magic-numbers,
+    -readability-named-parameter,
+    -readability-redundant-declaration,
+    -readability-simplify-boolean-expr,
+    -readability-static-accessed-through-instance,
+    -readability-suspicious-call-argument,
+    -readability-uppercase-literal-suffix,
+    -readability-use-anyofallof,
+
+    -zircon-*,
+'
 
 WarningsAsErrors: '*'
 
-ExtraArgs:
-# clang-tidy 17 started to complain (for unknown reasons) that various pragmas are unknown ("clang-diagnostic-unknown-pragmas").
-# This is technically a compiler error, not a clang-tidy error. We could litter the code base with more pragmas that suppress
-# this error but it is better to pass the following flag to the compiler:
-- '-Wno-unknown-pragmas'
-- '-Wno-unused-command-line-argument' # similar issue
-
 CheckOptions:
   readability-identifier-naming.ClassCase: CamelCase
   readability-identifier-naming.EnumCase: CamelCase

.github/ISSUE_TEMPLATE/85_bug-report.md

@@ -7,8 +7,6 @@ assignees: ''
 
 ---
 
-> Please make sure that the version you're using is still supported (you can find the list [here](https://github.com/ClickHouse/ClickHouse/blob/master/SECURITY.md#scope-and-supported-versions)).
-
 > You have to provide the following information whenever possible.
 
 **Describe what's wrong**
@@ -17,7 +15,7 @@ assignees: ''
 
 > A link to reproducer in [https://fiddle.clickhouse.com/](https://fiddle.clickhouse.com/).
 
-**Does it reproduce on the most recent release?**
+**Does it reproduce on recent release?**
 
 [The list of releases](https://github.com/ClickHouse/ClickHouse/blob/master/utils/list-versions/version_date.tsv)
 
@@ -34,11 +32,11 @@ assignees: ''
 **How to reproduce**
 
 * Which ClickHouse server version to use
-* Which interface to use, if it matters
+* Which interface to use, if matters
 * Non-default settings, if any
 * `CREATE TABLE` statements for all tables involved
 * Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
-* Queries to run that lead to an unexpected result
+* Queries to run that lead to unexpected result
 
 **Expected behavior**
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -12,7 +12,6 @@ tests/ci/cancel_and_rerun_workflow_lambda/app.py
 - Build/Testing/Packaging Improvement
 - Documentation (changelog entry is not required)
 - Bug Fix (user-visible misbehavior in an official stable release)
-- CI Fix or Improvement (changelog entry is not required)
 - Not for changelog (changelog entry is not required)
 
 

.github/actions/common_setup/action.yml

@@ -18,6 +18,9 @@ runs:
           echo "Setup the common ENV variables"
           cat >> "$GITHUB_ENV" << 'EOF'
           TEMP_PATH=${{runner.temp}}/${{inputs.job_type}}
+          REPO_COPY=${{runner.temp}}/${{inputs.job_type}}/git-repo-copy
+          IMAGES_PATH=${{runner.temp}}/images_path
+          REPORTS_PATH=${{runner.temp}}/reports_dir
           EOF
           if [ -z "${{env.GITHUB_JOB_OVERRIDDEN}}" ] && [ "true" == "${{inputs.nested_job}}" ]; then
             echo "The GITHUB_JOB_OVERRIDDEN ENV is unset, and must be set for the nested jobs"
@@ -27,4 +30,6 @@ runs:
       shell: bash
       run: |
           # to remove every leftovers
-          sudo rm -fr "$TEMP_PATH" && mkdir -p "$TEMP_PATH"
+          sudo rm -fr "$TEMP_PATH"
+          mkdir -p "$REPO_COPY"
+          cp -a "$GITHUB_WORKSPACE"/. "$REPO_COPY"/