Backport #51499 to 23.3: Fix segfault in MathUnary

ClickHouse · Jun 29, 2023 · 4070c25 · 4070c25
1 parent bc683c1
commit 4070c25
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/Functions/FunctionMathUnary.h b/src/Functions/FunctionMathUnary.h
@@ -154,6 +154,8 @@ class FunctionMathUnary : public IFunction
             using ColVecType = ColumnVectorOrDecimal<Type>;
 
             const auto col_vec = checkAndGetColumn<ColVecType>(col.column.get());
+            if (col_vec == nullptr)
+                return false;
             return (res = execute<Type, ReturnType>(col_vec)) != nullptr;
         };
 

diff --git a/tests/queries/0_stateless/02807_math_unary_crash.reference b/tests/queries/0_stateless/02807_math_unary_crash.reference
@@ -0,0 +1,2 @@
+1
+1
diff --git a/tests/queries/0_stateless/02807_math_unary_crash.sql b/tests/queries/0_stateless/02807_math_unary_crash.sql
@@ -0,0 +1,6 @@
+DROP TABLE IF EXISTS t10;
+CREATE TABLE t10 (`c0` Int32) ENGINE = MergeTree ORDER BY tuple();
+INSERT INTO t10 (c0) FORMAT Values (-1);
+SELECT 1 FROM t10 GROUP BY erf(-sign(t10.c0));
+SELECT 1 FROM t10 GROUP BY -sign(t10.c0);
+DROP TABLE t10;