Merge pull request #54412 from ClickHouse/backport/23.3/54385

Backport #54385 to 23.3: Check for overflow before addition in `analysisOfVariance` function
ClickHouse · Sep 11, 2023 · 5dc1611 · 5dc1611
2 parents d12863a + d6e97ea
commit 5dc1611
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/AggregateFunctions/Moments.h b/src/AggregateFunctions/Moments.h
@@ -459,6 +459,10 @@ struct AnalysisOfVarianceMoments
 
     void add(T value, size_t group)
     {
+        if (group == std::numeric_limits<size_t>::max())
+            throw Exception(ErrorCodes::BAD_ARGUMENTS, "Too many groups for analysis of variance (should be no more than {}, got {})",
+                MAX_GROUPS_NUMBER, group);
+
         resizeIfNeeded(group + 1);
         xs1[group] += value;
         xs2[group] += value * value;

diff --git a/tests/queries/0_stateless/02874_analysis_of_variance_overflow.reference b/tests/queries/0_stateless/02874_analysis_of_variance_overflow.reference
diff --git a/tests/queries/0_stateless/02874_analysis_of_variance_overflow.sql b/tests/queries/0_stateless/02874_analysis_of_variance_overflow.sql
@@ -0,0 +1 @@
+SELECT analysisOfVariance(1, 18446744073709551615); -- { serverError BAD_ARGUMENTS }