Merge pull request #61999 from Avogar/variant-number-bool

Don't treat Bool and number variants as suspicious in Variant type
ClickHouse · Mar 28, 2024 · 70bb85a · 70bb85a
2 parents 0244e08 + 043c625
commit 70bb85a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/Interpreters/parseColumnsListForTableFunction.cpp b/src/Interpreters/parseColumnsListForTableFunction.cpp
@@ -86,6 +86,10 @@ void validateDataType(const DataTypePtr & type_to_check, const DataTypeValidatio
                 {
                     for (size_t j = i + 1; j < variants.size(); ++j)
                     {
+                        /// Don't consider bool as similar to something (like number).
+                        if (isBool(variants[i]) || isBool(variants[j]))
+                            continue;
+
                         if (auto supertype = tryGetLeastSupertype(DataTypes{variants[i], variants[j]}))
                         {
                             throw Exception(

diff --git a/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference
@@ -0,0 +1 @@
+true
diff --git a/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql
@@ -0,0 +1,4 @@
+set allow_experimental_variant_type=1;
+set allow_suspicious_variant_types=0;
+select 'true'::Bool::Variant(UInt32, Bool);
+