Skip to content

Commit

Permalink
Merge pull request #61359 from ClickHouse/revert-61234-Avogar-patch-2
Browse files Browse the repository at this point in the history
Revert "Fix usage of session_token in S3 engine"
  • Loading branch information
antonio2368 committed Mar 14, 2024
2 parents 659463a + c6f0b2a commit a40401f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/Coordination/KeeperSnapshotManagerS3.cpp
Expand Up @@ -121,8 +121,7 @@ void KeeperSnapshotManagerS3::updateS3Configuration(const Poco::Util::AbstractCo
auth_settings.use_insecure_imds_request.value_or(false),
auth_settings.expiration_window_seconds.value_or(S3::DEFAULT_EXPIRATION_WINDOW_SECONDS),
auth_settings.no_sign_request.value_or(false),
},
credentials.GetSessionToken());
});

auto new_client = std::make_shared<KeeperSnapshotManagerS3::S3Configuration>(std::move(new_uri), std::move(auth_settings), std::move(client));

Expand Down
3 changes: 1 addition & 2 deletions src/Storages/StorageS3.cpp
Expand Up @@ -1451,8 +1451,7 @@ void StorageS3::Configuration::connect(const ContextPtr & context)
auth_settings.expiration_window_seconds.value_or(
context->getConfigRef().getUInt64("s3.expiration_window_seconds", S3::DEFAULT_EXPIRATION_WINDOW_SECONDS)),
auth_settings.no_sign_request.value_or(context->getConfigRef().getBool("s3.no_sign_request", false)),
},
credentials.GetSessionToken());
});
}

void StorageS3::processNamedCollectionResult(StorageS3::Configuration & configuration, const NamedCollection & collection)
Expand Down

0 comments on commit a40401f

Please sign in to comment.