Merge pull request #50083 from ClickHouse/backport/23.4/50058

Backport #50058 to 23.4: Fix crashing in case of Replicated database without arguments
ClickHouse · May 24, 2023 · cb2a461 · cb2a461
2 parents 37b8dc9 + 18a37dd
commit cb2a461
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/Interpreters/InterpreterCreateQuery.cpp b/src/Interpreters/InterpreterCreateQuery.cpp
@@ -227,7 +227,7 @@ BlockIO InterpreterCreateQuery::createDatabase(ASTCreateQuery & create)
         metadata_path = metadata_path / "metadata" / database_name_escaped;
     }
 
-    if (create.storage->engine->name == "Replicated" && !internal && !create.attach)
+    if (create.storage->engine->name == "Replicated" && !internal && !create.attach && create.storage->engine->arguments)
     {
         /// Fill in default parameters
         if (create.storage->engine->arguments->children.size() == 1)

diff --git a/tests/queries/0_stateless/02762_replicated_database_no_args.reference b/tests/queries/0_stateless/02762_replicated_database_no_args.reference
diff --git a/tests/queries/0_stateless/02762_replicated_database_no_args.sql b/tests/queries/0_stateless/02762_replicated_database_no_args.sql
@@ -0,0 +1,4 @@
+-- Tags: no-parallel
+
+set allow_experimental_database_replicated=1;
+create database replicated_db_no_args engine=Replicated; -- { serverError BAD_ARGUMENTS }