QueryNormalizer only checks stack size

ClickHouse · Oct 16, 2023 · d7c7742 · d7c7742
1 parent ba5cd01
commit d7c7742
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/Interpreters/QueryNormalizer.cpp b/src/Interpreters/QueryNormalizer.cpp
@@ -120,7 +120,6 @@ void QueryNormalizer::visit(ASTIdentifier & node, ASTPtr & ast, Data & data)
                 /// In a construct like "a AS b", where a is an alias, you must set alias b to the result of substituting alias a.
                 /// Check size of the alias before cloning too large alias AST
                 alias_node->checkSize(data.settings.max_expanded_ast_elements);
-                current_asts.insert(alias_node.get());
                 ast = alias_node->clone();
                 ast->setAlias(node_alias);
 
@@ -139,7 +138,6 @@ void QueryNormalizer::visit(ASTIdentifier & node, ASTPtr & ast, Data & data)
             /// Check size of the alias before cloning too large alias AST
             alias_node->checkSize(data.settings.max_expanded_ast_elements);
             auto alias_name = ast->getAliasOrColumnName();
-            current_asts.insert(alias_node.get());
             ast = alias_node->clone();
             ast->setAlias(alias_name);
 

diff --git a/tests/queries/0_stateless/02896_cyclic_aliases_crash.sql b/tests/queries/0_stateless/02896_cyclic_aliases_crash.sql
@@ -6,7 +6,7 @@ SELECT
     val + 1 as prev,
     val + prev as val
 FROM ( SELECT 1 as val )
-; -- { serverError CYCLIC_ALIASES }
+; -- { serverError CYCLIC_ALIASES, TOO_DEEP_RECURSION }
 
 
 SELECT