Avoid deadlock for syncing pinned part UUIDs on startup

CI: https://s3.amazonaws.com/clickhouse-test-reports/50777/14ecff6db4b603bba1529f9c2790488216e1d5e1/integration_tests__asan__[6_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

src/Storages/MergeTree/ReplicatedMergeTreeAttachThread.cpp

@@ -181,7 +181,7 @@ void ReplicatedMergeTreeAttachThread::runImpl()
     storage.clearOldWriteAheadLogs();
 
     storage.createNewZooKeeperNodes();
-    storage.syncPinnedPartUUIDs();
+    storage.syncPinnedPartUUIDs(/* startup= */ true);
 
     std::lock_guard lock(storage.table_shared_id_mutex);
     storage.createTableSharedID();

src/Storages/StorageReplicatedMergeTree.cpp

@@ -498,7 +498,7 @@ StorageReplicatedMergeTree::StorageReplicatedMergeTree(
     }
 
     createNewZooKeeperNodes();
-    syncPinnedPartUUIDs();
+    syncPinnedPartUUIDs(/* startup= */ true);
 
     if (!has_metadata_in_zookeeper.has_value() || *has_metadata_in_zookeeper)
         createTableSharedID();
@@ -1374,7 +1374,7 @@ void StorageReplicatedMergeTree::checkParts(bool skip_sanity_checks)
 }
 
 
-void StorageReplicatedMergeTree::syncPinnedPartUUIDs()
+void StorageReplicatedMergeTree::syncPinnedPartUUIDs(bool startup)
 {
     auto zookeeper = getZooKeeper();
 
@@ -1395,7 +1395,12 @@ void StorageReplicatedMergeTree::syncPinnedPartUUIDs()
         /// pinned_part_uuids, then it will receive some UUIds from remote
         /// shard, and only then pinned_part_uuids will be set, and this will
         /// lead to duplicated data.
-        auto exclusive_lock = lockExclusively(RWLockImpl::NO_QUERY, getContext()->getSettingsRef().lock_acquire_timeout);
+        TableExclusiveLockHolder exclusive_lock;
+        /// On startup we cannot take exclusive lock since some already held on
+        /// this storage (and it is not required, since this table is not
+        /// visible yet, though there is one exception - switching from readonly)
+        if (!startup)
+            exclusive_lock = lockExclusively(RWLockImpl::NO_QUERY, getContext()->getSettingsRef().lock_acquire_timeout);
         pinned_part_uuids = new_pinned_part_uuids;
     }
 }
@@ -1704,7 +1709,7 @@ bool StorageReplicatedMergeTree::executeLogEntry(LogEntry & entry)
         case LogEntry::ALTER_METADATA:
             return executeMetadataAlter(entry);
         case LogEntry::SYNC_PINNED_PART_UUIDS:
-            syncPinnedPartUUIDs();
+            syncPinnedPartUUIDs(/* startup= */ false);
             return true;
         case LogEntry::CLONE_PART_FROM_SHARD:
             executeClonePartFromShard(entry);

src/Storages/StorageReplicatedMergeTree.h

@@ -545,7 +545,7 @@ class StorageReplicatedMergeTree final : public MergeTreeData
 
     /// Synchronize the list of part uuids which are currently pinned. These should be sent to root query executor
     /// to be used for deduplication.
-    void syncPinnedPartUUIDs();
+    void syncPinnedPartUUIDs(bool startup);
 
     /** Check that the part's checksum is the same as the checksum of the same part on some other replica.
       * If no one has such a part, nothing checks.