addressing PR comments

ClickHouse · May 1, 2023 · e58a63b · e58a63b
1 parent c1f95f3
commit e58a63b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Storages/ColumnsDescription.cpp b/src/Storages/ColumnsDescription.cpp
@@ -662,7 +662,7 @@ bool ColumnsDescription::hasPhysical(const String & column_name) const
 bool ColumnsDescription::hasAlias(const String & column_name) const
 {
     auto it = columns.get<1>().find(column_name);
-    return it->default_desc.kind == ColumnDefaultKind::Alias;
+    return it != columns.get<1>().end() && it->default_desc.kind == ColumnDefaultKind::Alias;
 }
 
 bool ColumnsDescription::hasColumnOrSubcolumn(GetColumnsOptions::Kind kind, const String & column_name) const

diff --git a/tests/queries/0_stateless/02725_alias_columns_should_not_allow_compression_codec.sql b/tests/queries/0_stateless/02725_alias_columns_should_not_allow_compression_codec.sql
@@ -4,4 +4,4 @@ create table if not exists alias_column_should_not_allow_compression_fail ( user
 alter table alias_column_should_not_allow_compression modify column user_id codec(LZ4HC(1));
 alter table alias_column_should_not_allow_compression modify column user_id_hashed codec(LZ4HC(1)); -- { serverError BAD_ARGUMENTS }
 alter table alias_column_should_not_allow_compression add column user_id_hashed_1 UInt64 ALIAS (cityHash64(user_id)) codec(LZ4HC(1)); -- { serverError BAD_ARGUMENTS }
-
+drop table if exists alias_column_should_not_allow_compression;