Merge pull request #58358 from ClickHouse/format-constexpr

Make function `format` return a constant on constant arguments.
ClickHouse · Dec 30, 2023 · ebd9558 · ebd9558
2 parents 1d34402 + 9d8c263
commit ebd9558
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/src/Functions/format.cpp b/src/Functions/format.cpp
@@ -39,6 +39,7 @@ class FormatFunction : public IFunction
 
     size_t getNumberOfArguments() const override { return 0; }
 
+    bool useDefaultImplementationForConstants() const override { return true; }
     ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {0}; }
 
     DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override

diff --git a/tests/queries/0_stateless/02956_format_constexpr.reference b/tests/queries/0_stateless/02956_format_constexpr.reference
@@ -0,0 +1 @@
+1
diff --git a/tests/queries/0_stateless/02956_format_constexpr.sql b/tests/queries/0_stateless/02956_format_constexpr.sql
@@ -0,0 +1 @@
+SELECT isConstant(format('{}, world', 'Hello'));