Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer overflow is possible in token bloom filter full text index. #19233

Closed
alexey-milovidov opened this issue Jan 18, 2021 · 4 comments · Fixed by #22421
Closed

Buffer overflow is possible in token bloom filter full text index. #19233

alexey-milovidov opened this issue Jan 18, 2021 · 4 comments · Fixed by #22421
Assignees
@alexey-milovidov
Labels
fuzz Problem found by one of the fuzzers

Comments

@alexey-milovidov
Copy link
Member

https://clickhouse-test-reports.s3.yandex.net/19186/712bef8eef6912dc317e63a6e2e54d6c2d6cad7e/fuzzer_asan/server.log

2021.01.18 01:55:15.156623 [ 142 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeIndexFullText.cpp:721: DB::SplitTokenExtractor::next(char const*, unsigned long, unsigned long*, unsigned long*, unsigned long*) const @ 0x1fc57a20 in /workspace/clickhouse
2021.01.18 01:55:15.157650 [ 142 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeIndexFullText.cpp:51: DB::stringToBloomFilter(char const*, unsigned long, DB::ITokenExtractor const*, DB::BloomFilter&) @ 0x1fc4ad84 in /workspace/clickhouse
@alexey-milovidov alexey-milovidov added the fuzz Problem found by one of the fuzzers label Jan 18, 2021
@alexey-milovidov alexey-milovidov mentioned this issue Jan 18, 2021
Merged
@alexey-milovidov
Copy link
Member Author

CC @Enmk

@alexey-milovidov
Copy link
Member Author

https://clickhouse-test-reports.s3.yandex.net/19862/e23dc60e31f5856b4b8f910fdbaba6b885b715d1/fuzzer_asan/server.log

@alexey-milovidov alexey-milovidov mentioned this issue Jan 31, 2021
Merged
@tavplubix tavplubix mentioned this issue Feb 5, 2021
Merged
@alexey-milovidov alexey-milovidov mentioned this issue Feb 11, 2021
Merged
@alexey-milovidov alexey-milovidov mentioned this issue Feb 21, 2021
Merged
@alexey-milovidov
Copy link
Member Author

The bug introduced here: #9968

@alexey-milovidov
Copy link
Member Author

Something is really wrong with this index: https://clickhouse-test-reports.s3.yandex.net/22411/5cd1dc485fbc5b8767f76e3abbb81c63218a6532/fuzzer_tsan/report.html#fail1

@alexey-milovidov alexey-milovidov mentioned this issue Mar 31, 2021
Merged
@alexey-milovidov alexey-milovidov self-assigned this Apr 1, 2021
@alexey-milovidov alexey-milovidov mentioned this issue Apr 1, 2021
Merged
alexey-milovidov added a commit that referenced this issue Apr 1, 2021
@alexey-milovidov
Fix buffer overflow in TokenExtractor #19233
7db8fcd
@alexey-milovidov alexey-milovidov mentioned this issue Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-milovidov alexey-milovidov

Labels
fuzz Problem found by one of the fuzzers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix buffer overflow in token extractor ClickHouse/ClickHouse
1 participant
@alexey-milovidov