Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to send revision over HTTP for native format #40397

Closed
gingerwizard opened this issue Aug 19, 2022 · 4 comments
Closed

Allow to send revision over HTTP for native format #40397

gingerwizard opened this issue Aug 19, 2022 · 4 comments
Labels
feature warmup task The task for new ClickHouse team members. Low risk, moderate complexity, no urgency.

Comments

@gingerwizard
Copy link
Contributor

Currently we can't get timezone information for datetime columns as this isn't returned - see #38209

Request that we be able to send a revision number over HTTP as a parameter so this information is returned.
@gingerwizard gingerwizard mentioned this issue Aug 19, 2022
Open
@alexey-milovidov alexey-milovidov added the warmup task The task for new ClickHouse team members. Low risk, moderate complexity, no urgency. label Dec 18, 2022
@alexey-milovidov alexey-milovidov mentioned this issue Feb 9, 2023
Closed
@genzgd
Copy link
Contributor

genzgd commented Feb 9, 2023

At what point do we sunset backward compatibility? The timezone format change was in release 1.1.54337, which is January 18, 2018, more than five years ago. Maybe we could remove some of those checks?

This was referenced Feb 10, 2023
Closed
Merged
@genzgd
Copy link
Contributor

genzgd commented Feb 13, 2023

Draft PR with a rough fix for this: #46360 -- needs tests and I'm not sure sticking the revision in the Context is the right approach.

@jkaflik
Copy link
Contributor

jkaflik commented Feb 20, 2023

Well done @genzgd ! Thanks

@mshustov
Copy link
Member

@genzgd #46360 is merged. Can we close the issue?

@genzgd genzgd closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature warmup task The task for new ClickHouse team members. Low risk, moderate complexity, no urgency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jkaflik @genzgd @mshustov @gingerwizard @alexey-milovidov