New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload build time-trace data to CI database #53100
Conversation
This is an automated comment for commit b397d11 with description of existing statuses. It's updated for the latest CI running
|
docker/test/style/Dockerfile
Outdated
@@ -19,7 +19,8 @@ RUN apt-get update && env DEBIAN_FRONTEND=noninteractive apt-get install --yes \ | |||
shellcheck \ | |||
yamllint \ | |||
locales \ | |||
&& pip3 install black==23.1.0 boto3 codespell==2.2.1 mypy==1.3.0 PyGithub unidiff pylint==2.6.2 \ | |||
&& pip3 install black==23.1.0 boto3 codespell==2.2.1 mypy==1.3.0 PyGithub unidiff pylint==2.6.2 types-requests=2.31.0.2 types-urllib3=1.26.25.14 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's unnecessary change, we don't use additional stubs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But mypy
told me about it in clear text.
tests/ci/build_check.py
Outdated
import subprocess | ||
import logging | ||
import json | ||
import os | ||
import sys | ||
import time | ||
from typing import List, Tuple | ||
import urllib.parse | ||
import requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, the goal is to use the same DB as for checks, so https://github.com/ClickHouse/ClickHouse/blob/master/tests/ci/clickhouse_helper.py#L18 would be extended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we will use a separate DB because the DB with checks is capped at about 3.6 TB, while ClickHouse Cloud is unlimited.
@@ -3,6 +3,9 @@ name: BackportPR | |||
env: | |||
# Force the stdout and stderr streams to be unbuffered | |||
PYTHONUNBUFFERED: 1 | |||
# Export system tables to ClickHouse Cloud | |||
CLICKHOUSE_CI_LOGS_HOST: ${{ secrets.CLICKHOUSE_CI_LOGS_HOST }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use the SSM for this purpose, and this function https://github.com/ClickHouse/ClickHouse/blob/master/tests/ci/get_robot_token.py#L18
|
…se into upload-build-profile
…se into upload-build-profile
Ok. It works, and the amount of changes is minimal. |
I don't get the purpose of the review if it's just ignored completely and merged. A new image has broken everything again |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The compiler's profile data (
-ftime-trace
) is uploaded to ClickHouse Cloud.