Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.3.13 Pre-release #310

Merged
merged 93 commits into from Oct 5, 2023
Merged

23.3.13 Pre-release #310

merged 93 commits into from Oct 5, 2023

Conversation

Enmk
Copy link
Member

@Enmk Enmk commented Sep 25, 2023

Changes compared to upstream's v23.3.13.6-lts

Bug fixes

Performance improvement

Improvement

Build/Testing/Packaging Improvement

Upstream changes between v23.3.8.21-lts (1675f2264f3) and v23.3.13.6-lts (25635e27551)

Performance Improvement

  • Backported in #52213: Do not store blocks in ANY hash join if nothing is inserted. #48633 (vdimir).
  • Backported in #52826: Fix incorrect projection analysis which invalidates primary keys. This issue only exists when query_plan_optimize_primary_key = 1, query_plan_optimize_projection = 1 . This fixes #48823 . This fixes #51173 . #52308 (Amos Bird).

Build/Testing/Packaging Improvement

Bug Fix (user-visible misbehavior in an official stable release)

NOT FOR CHANGELOG / INSIGNIFICANT

Enmk and others added 30 commits June 13, 2023 16:03
add comment and rename github robot token
add clickhouse instance password parameter
use Altinity's s3 bucket
Use altinityinfra dockerhub images and minor adjustments (#135)
Allow CI to be triggered on PR
Proper error reporting during docker pull and lowercase version name
allow `altinitystable` git tags
Download specific MinIO version instead of latest - same as upstream master
remove stale chmod
More stable CI/CD builds:
- Rebuilding all docker images
- Reduced number of docker images
- Rerunning functional tests even if those were already executed in previous run
Added missing dependencies for stateful tests
Re-generating _pb2 files on each test run
Changed hardcoded docker images name prefixes from `clickhouse/` to `altinityinfra/`
Pushing images as :latest too to avoid some test failures
reverted back to use clickhouse/jdbc-bridge
Fixed how version is generated: taking into account VERSION_TWEAK and VERSION_FLAVOUR
Pushing checks events data to "gh-data" instead of "default"
Using secrets for managing AWS access
Fixed tag checking code to allow altinitystable version suffix
Bumped Go version to get some CVE fixes
Do not install clickhouse-diagnostics due to numerous CVEs in go runtime
Removed unneeded docker images from list: codebrowser, sqlancer-test, keeper-jespen, keeper-jepsen-test, testflows-runner, fuzzer
Using ccache instead of sccache
Fixed ClickHouseVersion.get_version_from_string for some cases, fixed getting version flavour
Fix key condition on duplicate primary keys
…sary-sets

Do not build sets for skip indexes if they are not used
…uild_skip_indices_if_not_used

23.3 backport of ClickHouse#48299 Do not build skip indices if not used
…condition_crash

23.3 backport of ClickHouse#48838 Fix crash with key condition on duplicate primary keys
Uploading src tgz and regression improvements
Changed order of jobs to make SignRelease start earlier than tests, and tests start after SignRelease
…s_coredns_version

23.3 Backport of ClickHouse#53286 - Bring back **garbage** dns tests
MyroTk and others added 12 commits September 15, 2023 10:00
…xpressions

Disable "compile_expressions" setting by default
…lickHouse#50429)

Previously it could create MergeTreeInOrder for each mark, however this
could be very suboptimal, due to each MergeTreeInOrder has some memory
overhead.

Now, by collapsing all marks for one part together it is more memory
effiecient.

I've tried the query from the altinity wiki [1] and it decreases memory
usage twice:

    SELECT * FROM repl_tbl FINAL WHERE key IN (SELECT toUInt32(number) FROM numbers(1000000) WHERE number % 50000 = 0) FORMAT Null

- upstream: MemoryTracker: Peak memory usage (for query): 520.27 MiB.
- patched:  MemoryTracker: Peak memory usage (for query): 260.95 MiB.

  [1]: https://kb.altinity.com/engines/mergetree-table-engine-family/replacingmergetree/#multiple-keys

And it could be not 2x and even more or less, it depends on the gaps in
marks for reading (for example in my setup the memory usage increased a
lot, from ~16GiB of RAM to >64GiB due to lots of marks and gaps).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
…compile_expressions

23.3 Backport of ClickHouse#51368 - Disable "compile_expressions" setting by default
other IPv6 addr, explicit 8.8.8.8 dns

(cherry-picked a028c29)
…uet_array_inconsistent_offsets

23.3 Backport of ClickHouse#54370 - fix parquet array inconsistent offsets
…l-memory-usage

23.3 Backport of ClickHouse#50429 - Fix excessive memory usage for FINAL (due to too much streams usage)
Updating labels for on-demand runners
@altinity-robot
Copy link
Collaborator

altinity-robot commented Sep 25, 2023

This is an automated comment for commit bac54d0 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🔴 failure
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success

@Enmk

This comment has been minimized.

MyroTk and others added 11 commits September 28, 2023 08:30
…_data_skipping_index

Fixed tests for queries/0_stateless/02780_final_streams_data_skipping…
Fix FINAL produces invalid read ranges in a rare case
…invalid_read_ranges

Backport of ClickHouse#54934 Fix `FINAL` produces invalid read ranges in a rare case
…eload

Fix reading from sparse columns after restart
…-columns-reload

23.3 Backport of ClickHouse#49660 - fix sparse columns reload
@Enmk Enmk merged commit f040635 into releases/23.3.13 Oct 5, 2023
106 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants