Clickhouse server no longer initializes default database

[jktng]

Hey folks, as of this morning's v24.1.4.20 release it looks like the database initialization step is erroneously skipped.

I have a Github test workflow that launches a Clickhouse container from the latest image, and as of <5 hours ago the default database is no longer being created on container start. This corresponds with when we began pulling the 24.1.4.20 image.

At a glance, #59808 looks relevant. Is this check supposed to be inverted?

[th0th]

I am not sure if it is the same issue, but when running in docker CLICKHOUSE_DB environment variable seems to ignored, and instead a database with name default is created. I noticed when my tests start to fail 😅

[littlebtc]

We also hit it in 23.12.x branch. After seeing comment and looking for source code, it seems that the following version had #59808 backported but not have this (#59991) backported:

• 23.3
• 23.8
• 23.12 (also 23)
• 24.1

Using Docker with the version listed above will still hit this issue. If you need any workaround to continue using those versions, see the referenced pull requests in #59808.