Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to run init db scripts every time #59808

Merged
merged 1 commit into from Feb 12, 2024

Conversation

AlexNik
Copy link
Contributor

@AlexNik AlexNik commented Feb 9, 2024

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

If you want to run initdb scripts every time when ClickHouse container is starting you shoud initialize environment varible CLICKHOUSE_ALWAYS_RUN_INITDB_SCRIPTS.

Documentation entry for user-facing changes

Add env variable CLICKHOUSE_ALWAYS_RUN_INITDB_SCRIPTS.

@evillique evillique added the can be tested Allows running workflows for external contributors label Feb 9, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-build Pull request with build/testing/packaging improvement label Feb 9, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Feb 9, 2024

This is an automated comment for commit 68df201 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@AlexNik
Copy link
Contributor Author

AlexNik commented Feb 12, 2024

Improvement of #50724

@AlexNik
Copy link
Contributor Author

AlexNik commented Feb 12, 2024

@Felixoid Could you review?

@Felixoid
Copy link
Member

Yes, looks good.

@Felixoid Felixoid self-assigned this Feb 12, 2024
@Felixoid Felixoid merged commit 1285bdb into ClickHouse:master Feb 12, 2024
211 of 310 checks passed
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Feb 12, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 12, 2024
…057de50c66b0af0232922300ec6ef

Cherry pick #59808 to 23.3: Option to run init db scripts every time
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 12, 2024
…057de50c66b0af0232922300ec6ef

Cherry pick #59808 to 23.8: Option to run init db scripts every time
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 12, 2024
…3057de50c66b0af0232922300ec6ef

Cherry pick #59808 to 23.11: Option to run init db scripts every time
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 12, 2024
…3057de50c66b0af0232922300ec6ef

Cherry pick #59808 to 23.12: Option to run init db scripts every time
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 12, 2024
…057de50c66b0af0232922300ec6ef

Cherry pick #59808 to 24.1: Option to run init db scripts every time
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 12, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 12, 2024
Backport #59808 to 23.12: Option to run init db scripts every time
robot-ch-test-poll4 added a commit that referenced this pull request Feb 12, 2024
Backport #59808 to 24.1: Option to run init db scripts every time
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 12, 2024
Backport #59808 to 23.11: Option to run init db scripts every time
Felixoid added a commit that referenced this pull request Feb 13, 2024
Backport #59808 to 23.8: Option to run init db scripts every time
Felixoid added a commit that referenced this pull request Feb 13, 2024
Backport #59808 to 23.3: Option to run init db scripts every time
Slach added a commit to Altinity/clickhouse-backup that referenced this pull request Mar 6, 2024
Slach added a commit to Altinity/clickhouse-backup that referenced this pull request Mar 6, 2024
Slach added a commit to Altinity/clickhouse-backup that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-build Pull request with build/testing/packaging improvement pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants