Date as a number in INSERT VALUES may fail or slow down

[den-crane]

Probably it's an undefined behavior.
May be better to forbid to insert Date as a number in Values, because TSV does not allow this.

create table vtest(A String, B Int64, C Int64, D Date) Engine=Memory;

19.15.5.18 -- fails if number of values is high

clickhouse-client -q "select 'refcode',4,1,17587 from numbers(1000) format Values">test1k.value

time cat test1k.value |clickhouse-client -q "INSERT INTO vtest Values"
real	0m0.075s

clickhouse-client -q "select 'refcode',4,1,17587 from numbers(1000000) format Values" >test1m.value

cat test1m.value |clickhouse-client -q "INSERT INTO vtest Values"
Code: 27. DB::Exception: Cannot parse input: expected ) before: 87),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\'refcode\',4,1,17587),(\': (at row 5958)

19.18.1.1779 -- 53 seconds!!!

time cat  test1m.value |clickhouse-client -q "INSERT INTO vtest Values"
real	0m53.000s

[filimonov]

Maybe related to #6781

/cc @tavplubix

[tavplubix]

It should work fine with enabled input_format_values_deduce_templates_of_expressions setting.

$ time cat test1m.value |clickhouse-client -q "INSERT INTO vtest Values" --input_format_values_deduce_templates_of_expressions=1
real	0m0.321s
user	0m0.247s
sys	0m0.051s

https://clickhouse.yandex/docs/en/operations/settings/settings/#settings-input_format_values_deduce_templates_of_expressions

Also inserting date as a number can be forbidden by disabling input_format_values_interpret_expressions setting.

[alexey-milovidov]

@tavplubix Are we ready to enable it by default? You can make a PR with this change.