Fix dictionary name (RELOAD and system.dictionaries) after DETACH/ATTACH #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the case when the server is starting.
After DETACH/ATTACH (or at server startup) the following will be broken: - SYSTEM RELOAD DICTIONARY db_name.dict_name - system.dictionaries will not have database for those dictionaries The problem is that after DETACH/ATTACH the dictionary information is obtained from metadata/$db/$dict.sql, but it does not have database name. Fix this by passing database name to the getDictionaryConfigurationFromAST(). Introduced-in: ClickHouse#10234
AFAICS the clang |
alexey-milovidov
approved these changes
Apr 21, 2020
CurtizJ
added
pr-bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix dictionary name (RELOAD and system.dictionaries) after DETACH/ATTACH
Detailed description / Documentation draft:
Introduced-in: #10234 (yet another fix for dictionaries loading)
Cc: @vitlibar