Add geo data types Point and Polygon #10678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added
can be tested
st-waiting-for-fix
| namespace | ||
| { | ||
|
|
||
| class DataTypeCustomPointSerialization : public DataTypeCustomSimpleTextSerialization |
There was a problem hiding this comment.
Missing comments with description.
|
The code LGTM. Let's merge and start using it :) We also have to introduce a setting |
|
We need to add a setting |
alexey-milovidov
added a commit
that referenced
this pull request
May 31, 2020
alexey-milovidov
approved these changes
May 31, 2020
Will fix after merge. |
alexey-milovidov
added a commit
that referenced
this pull request
May 31, 2020
alexey-milovidov
added a commit
that referenced
this pull request
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add data type Point (Tuple(Float64, Float64)) and Polygon (Array(Array(Tuple(Float64, Float64)))