CUDA aggregate functions prototype #11083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
qoega
reviewed
May 21, 2020
| #if USE_CUDA | ||
| LOG_INFO(log, "Initializaing CUDA context"); | ||
| //cudaInitDevice(0, 8589934592); | ||
| cudaInitDevice(0, 17179869184); |
There was a problem hiding this comment.
Can you add a comment about magic number?
Closed
|
Cancelled. This PR will be left as an example for the case when this direction of work will be considered again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add experimental GPU accelerated aggregation functions started here #9503
Detailed description / Documentation draft:
Add
count()anduniq()functions underuse_cuda_aggregationsetting