Opt-in support for sending crash reports

[blinkov]

Changelog category (leave one):

• New Feature

A crash report looks roughly like this:

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Opt-in settings to send crash reports to the ClickHouse core team via Sentry.

[alexey-milovidov]

Capture unhandled exceptions

Unhandled exception is processed with std::terminate and abort, then it will be processed with signal handler.

[filimonov]

I like the idea, i like Sentry :)

2 doubts:

1. transparency - store reports sended to be able to review what sended
2. anonimization - have an ability to remove all hostnames / ips

[blinkov]

transparency - store reports sended to be able to review what sended

@filimonov Sentry SDK doesn't seem to have such an option, the closest thing I see is using an HTTP proxy, where you can dump what goes through. We could file an issue in https://github.com/getsentry/sentry-native though, maybe they'll suggest/add something.

[blinkov]

Maybe there is some regression in stack trace formatting speed?

@alexey-milovidov doesn't look like it, I've restored the previous stacktrace-to-string code and it behaves the same in these tests.

[alexey-milovidov]

@blinkov If I understand correctly it means that the cache for stack traces was made ineffective, so we got performance degradation + memory leak. I'm glad that it is fixed and we have a test that showed the issue.

It is time for you to say respect to our testing infrastructure and to all the developers who spend their time making it better (@alesapin) and to all the developers who write tests. So you can make this contribution flawlessly and without any regressions.

[alexey-milovidov]

Performance tests did not run because they were accidentially disabled.

Stress test (thread) Pending — Started

Did not finish in 6 hours.

Functional stateless tests (unbundled) — fail: 1, passed: 1951, skipped: 41

Reported as flaky test.

[Slach]

@blinkov should </send_crash_reports> here instead of </logger> ?

[blinkov]

@Slach yes, thanks

[azat]

This should contain the library name, not the path, i.e. simply curl

Right now the build reports the following warnings:

2020-06-25 08:39:30 WARNING: Target "sentry" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "daemon" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse-server-lib" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse-local-lib" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse-copier-lib" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse-odbc-bridge" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.
2020-06-25 08:39:30 WARNING: Target "clickhouse-odbc-bridge-lib" requests linking to directory "/build/contrib/curl/lib".  Targets may link only to libraries.  CMake is dropping the item.

P.S. everything works because of the following explicit linking with curl:

if (USE_SENTRY)
    target_link_libraries (daemon PRIVATE curl) # <<
    target_link_libraries (daemon PRIVATE ${SENTRY_LIBRARY})
endif ()

[alexey-milovidov]

@azat I have the same issue. Could you please make a pull request with fix?

[azat]

#12041