Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system.asynchronous_metric_log #11588

Merged
merged 3 commits into from Jun 11, 2020
Merged

Add system.asynchronous_metric_log #11588

merged 3 commits into from Jun 11, 2020

Conversation

akuzm
Copy link
Contributor

@akuzm akuzm commented Jun 10, 2020

I needed it again today, time to add.

Fixes #9429

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add the system.asynchronous_metric_log table that logs historical metrics from system.asynchronous_metrics.

@blinkov blinkov added doc-alert pr-feature Pull request with new product feature labels Jun 10, 2020
@alexey-milovidov alexey-milovidov self-assigned this Jun 10, 2020
Asynchronous metrics are updated once a minute, so there is
no need to flush often.
-->
<flush_interval_milliseconds>300000</flush_interval_milliseconds>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it Ok if we will write it also once a minute by default? (why less frequent?)

@akuzm
Copy link
Contributor Author

akuzm commented Jun 11, 2020

  • PVS studio doesn't like the getLock in context for some reason -- a false positive
  • Performance test is broken in master

@akuzm
Copy link
Contributor Author

akuzm commented Jun 11, 2020

  • Doc check -- Ivan Blinkov says that he fixed it in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system.asynchronous_metric_log table
3 participants