Fix corner case (only) for exit code overflow #11601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
approved these changes
Jun 11, 2020
|
PVS Ok. |
|
NULL pointer in 2020.06.11 18:12:51.946411 [ 14042 ] {} BaseDaemon: 5. /build/obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeData.cpp:1640: DB::MergeTreeData::PartsTemporaryRename::tryRenameAll() @ 0x10f0f2bb in /usr/bin/clickhouse - something new... |
vitlibar
pushed a commit
that referenced
this pull request
Jun 19, 2020
Fix corner case (only) for exit code overflow (cherry picked from commit d5c2008)
vitlibar
pushed a commit
that referenced
this pull request
Jun 19, 2020
Fix corner case (only) for exit code overflow (cherry picked from commit d5c2008)
vitlibar
pushed a commit
that referenced
this pull request
Jun 20, 2020
Fix corner case (only) for exit code overflow (cherry picked from commit d5c2008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong exit code of the clickhouse-client, when exception.code() % 256 = 0.
Detailed description / Documentation draft:
Fixes #11581. Other status codes should stay as is now (so @vzakaznikov's tests will not blow up).