Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comparison of numbers with constant string in IN and VALUES #11647

Merged
merged 14 commits into from Jun 15, 2020

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow comparison of numbers with constant string in comparison operators, IN and VALUES sections.

Detailed description / Documentation draft:
Also includes #11646. This does not fix #11630 because comparison for index is not covered by this PR.

@blinkov blinkov added the pr-improvement Pull request with some product improvements label Jun 13, 2020
@alexey-milovidov alexey-milovidov force-pushed the simplify-code-functions-comparison-2 branch from acf14fe to bba0140 Compare June 14, 2020 04:21
@alexey-milovidov
Copy link
Member Author

Performance test Ok.

@alexey-milovidov alexey-milovidov merged commit 550838a into master Jun 15, 2020
@alexey-milovidov alexey-milovidov deleted the simplify-code-functions-comparison-2 branch June 15, 2020 00:33
@filimonov
Copy link
Contributor

This does not fix #11630

But st-fixed label added and issue closed :)

@alexey-milovidov
Copy link
Member Author

@filimonov
Follow-up PR is also merged.

@qoega
Copy link
Member

qoega commented Jul 27, 2020

We should mention it in docs with examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: automatic type cast of literals in obvious cases
4 participants