Cherry pick #11840 to 20.5: Fix memory accounting via HTTP interface #11961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function perf_test()
{
time yes '127.1:8123/?wait_end_of_query=1' | head -n10000 | xargs -P10000 curl -s -d 'select 1' | grep -x -c 1
}
function server()
{
local limit=$1 && shift
clickhouse-server "$@" -- --max_server_memory_usage=$limit
}
perf_test:
- before this patch with 1G limit: succeed only ~800 queries
- after this patch with 1G limit: succeed ~8000 queries
- before this patch with 10G limit: succeed only ~3000 queries
- after this patch with 10G limit: succeed ~10000 queries
Fixes: #11153
w/o the patch the test fails with, since it succeed only 512 queries.
Actually there were two issues: - missing \n, so it picked the wrong query anway - no unique identifier, hence it may works incorrectly (and actually, event clickhouse-test script executes 'SELECT 1' query)
Fix memory accounting via HTTP interface
abyss7
added
do not test
abyss7
deleted the
cherrypick/20.5/b4475086abbceff19401bbc5b99b1716934b2827
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull-request #11840