Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix over-limiting the number of threads for union. #12103

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Conversation

KochetovNicolai
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix performance for selects with UNION caused by wrong limit for the total number of threads. Fixes #12030

@blinkov blinkov added the pr-bugfix Pull request with bugfix, not backported by default label Jul 3, 2020
@alexey-milovidov alexey-milovidov self-assigned this Jul 3, 2020
@alexey-milovidov alexey-milovidov added the st-waiting-for-fix We are waiting for fixes in this issue or pull request label Jul 5, 2020
@alexey-milovidov
Copy link
Member

Performance test: 4 faster

Great result!

@alexey-milovidov alexey-milovidov removed the st-waiting-for-fix We are waiting for fixes in this issue or pull request label Jul 9, 2020
@alexey-milovidov alexey-milovidov merged commit cbb539c into master Jul 9, 2020
@alexey-milovidov alexey-milovidov deleted the fix-12030 branch July 9, 2020 01:28
alexey-milovidov added a commit that referenced this pull request Jul 10, 2020
…52d9844f43251cbe61ace74bf862c

Cherry pick #12103 to 20.5: Fix over-limiting the number of threads for union.
KochetovNicolai pushed a commit that referenced this pull request Jul 20, 2020
Fix over-limiting the number of threads for union.

(cherry picked from commit cbb539c)
KochetovNicolai pushed a commit that referenced this pull request Jul 20, 2020
Fix over-limiting the number of threads for union.

(cherry picked from commit cbb539c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processors performance downgrade with UNION & LIMIT
4 participants