Add query context for system logs and to Buffer #12120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to allow attaching materialized views with joins or with subqueries to system.logs.
filimonov
commented
Jul 3, 2020
tavplubix
reviewed
Jul 3, 2020
src/Interpreters/SystemLog.h
Outdated
| @@ -161,6 +161,7 @@ class SystemLog : public ISystemLog, private boost::noncopyable | |||
| private: | |||
| /* Saving thread data */ | |||
| Context & context; | |||
There was a problem hiding this comment.
It would be great to rename it to global_context and make the reference const
There was a problem hiding this comment.
Changing it to const - not possible for now (there are few uses of context in logs). Also kept the existing name, for now, to make backporting smoother.
filimonov
changed the title
tavplubix
approved these changes
Jul 7, 2020
tavplubix
pushed a commit
that referenced
this pull request
Jul 7, 2020
tavplubix
pushed a commit
that referenced
this pull request
Jul 8, 2020
…Buffer (#12243) Co-authored-by: Alexander Tokmakov <avtokmakov@sandbox-407922969>
filimonov
added a commit
to filimonov/ClickHouse
that referenced
this pull request
Jul 10, 2020
Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. Fix ClickHouse#10437, CR fixes Sync reference file with changes in sql file Same change for Kafka - just in case, and to make it conform.
filimonov
added a commit
to filimonov/ClickHouse
that referenced
this pull request
Jul 10, 2020
Add missing query context for system logs Needed to allow attaching materialized views with joins or with subqueries to system.logs. Fix ClickHouse#10437, CR fixes Sync reference file with changes in sql file Same change for Kafka - just in case, and to make it conform.
alesapin
pushed a commit
that referenced
this pull request
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to allow attaching materialized views with joins or with subqueries to system.logs or to engine=Buffer underlying table.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid "There is no query" exception for materialized views with joins or with subqueries attached to system logs (system.query_log, metric_log, etc) or to engine=Buffer underlying table.
Detailed description / Documentation draft:
Fixes #10437
Fixes #10285
Fixes #8670