Fix test under thread fuzzer #12154
Merged
Fix test under thread fuzzer #12154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blinkov
added
the
pr-not-for-changelog
tavplubix
reviewed
Jul 6, 2020
| @@ -19,7 +19,7 @@ threads=10 | |||
| count_multiplier=1 | |||
| max_time_ms=1000 | |||
|
|
|||
| debug_or_sanitizer_build=`$CLICKHOUSE_CLIENT -q "WITH ((SELECT value FROM system.build_options WHERE name='BUILD_TYPE') AS build, (SELECT value FROM system.build_options WHERE name='CXX_FLAGS') as flags) SELECT build='Debug' OR flags LIKE '%fsanitize%'"` | |||
| debug_or_sanitizer_build=`$CLICKHOUSE_CLIENT -q "WITH ((SELECT value FROM system.build_options WHERE name='BUILD_TYPE') AS build, (SELECT value FROM system.build_options WHERE name='CXX_FLAGS') as flags) SELECT build='Debug' OR flags LIKE '%fsanitize%' OR hasThreadFuzzer()"` | |||
There was a problem hiding this comment.
Do I understand correctly, that thread fuzzer will be enabled for all test configurations? In this case it's probably better just to increase max_time_ms.
There was a problem hiding this comment.
It's unclear how it will be enabled, maybe it will be a separate test run
(but it happens to be useful both in ASan and TSan)
There was a problem hiding this comment.
It will be perfect if it will be enabled for all tests including stress and integration (and not including performance).
But I'm still not sure - it can slow down tests too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):