SystemLog: do not log under mutex #12452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
|
@nikitamikhaylov I did not notice that you already have another pull request. |
|
Will be continued in #12339 |
alexey-milovidov
pushed a commit
that referenced
this pull request
Jul 21, 2020
…utex SystemLog: do not log under mutex (cherry picked from commit 1bef33f)
alexey-milovidov
pushed a commit
that referenced
this pull request
Jul 21, 2020
…utex SystemLog: do not log under mutex (cherry picked from commit 1bef33f)
alexey-milovidov
added a commit
that referenced
this pull request
Jul 23, 2020
…aa858a59e6fb997788b265e2cbb71 Cherry pick #12452 to 20.6: SystemLog: do not log under mutex
This was referenced Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jul 28, 2020
Backport #12452 to 20.3: SystemLog: do not log under mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
SystemLog: do not write to ordinary server log under mutex. This can lead to deadlock if
text_logis enabled.Details:
No test case is provided.